No More Posting New Topics!

If you have a question or an issue, please start a thread in our Github Discussions Forum.
This forum is closed for new threads/ topics.

Navigation

    Quasar Framework

    • Login
    • Search
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Groups
    • Search

    What are the rules for submitting a pull request

    Help
    2
    6
    213
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • markchagers
      markchagers last edited by

      Hi,
      I’m new here, but I’m really excited about Quasar and look forward to using it in my projects. Since a lot of my work will be done in the dutch language, I had a look at the iln8 nl.js translations. I would like to submit a pull request with a few corrections (I am a native dutch speaker) and I wondered whether there are any rules to be observed with submitting a pull request.

      1 Reply Last reply Reply Quote 0
      • markchagers
        markchagers last edited by

        Never mind, found it already:
        https://github.com/quasarframework/quasar/blob/dev/.github/CONTRIBUTING.md

        1 Reply Last reply Reply Quote 0
        • rstoenescu
          rstoenescu Admin last edited by

          Looking forward to your PR!

          1 Reply Last reply Reply Quote 0
          • markchagers
            markchagers last edited by

            Cool! Bit of a problem though: I wanted to make a pull request against the dev branch, as required, but that branch doesn’t seem to contain any localisation files, so there’s nothing to make a pull request against.

            1 Reply Last reply Reply Quote 0
            • rstoenescu
              rstoenescu Admin last edited by

              https://help.github.com/en/articles/creating-a-pull-request

              https://github.com/quasarframework/quasar/blob/dev/quasar/lang/nl.js

              1 Reply Last reply Reply Quote 0
              • markchagers
                markchagers last edited by

                https://github.com/quasarframework/quasar/pull/3616

                1 Reply Last reply Reply Quote 0
                • First post
                  Last post